-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green Beret sprite fix #5566
Merged
Merged
Green Beret sprite fix #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Remove the soul from the game.
Fix
Fix one bug, make ten more
labels
Jan 27, 2024
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Jan 30, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Jan 30, 2024
nauticall
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprites 👍
harryob
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fix
Fix one bug, make ten more
Sprites Approved
confirmed no stray pixels
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
fixes #3573
Reuses existing rmc beret, which are green. it fits the beret theme, and compared to red beret, it is a great match.
Please do note that black and red beret have weird sprites compared to other beret. This is not the case when worn, however something to note.
Explain why it's good for the game
Invisible sprites are bad
Testing Photographs and Procedure
--Testing--
Screenshots & Videos
Changelog
🆑
fix: character pref Green Beret is no longer invisible
/:cl: